FSR-1043 - fix unhandled 500 errors on /rainfall-station endpoints #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 26, 2023 11:57
Update error handling on rainfall-station and rainfall-station-csv route
maxcbc
changed the title
|
Kudos, SonarCloud Quality Gate passed! |
maxcbc
changed the title
LeeGordon83
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR should be tested/released in tandem with DEFRA/flood-service#150
What
getRainfallStation()to expect object from flood-service rather than an arraygetRainfallStation()to expect object rather than an arraygetRainfallStation()to respond 404 if no object is returned from the function